Optionally Skip Push for "envify" #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be in favor of having this be the default behavior, but maybe having a flag like |
|
You mean - default will be not doing push and then adding |
|
I think the flag should be '--skip-push' (kabob case) to match the same flag from 'kamal deploy'. |
rience
force-pushed
the
optional-envify-push
branch
from
33ac8dc
to
8ca0403
Compare
|
We push the env file by default because:
But it makes sense to have this flag in cases where you don't want to push immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing ".env" to remote host is not always required. If you just want to manage containers, traefik or accessories and initial push has already been done, that's adding additional step. Additionally - it reduces a risk of pushing incorrect ".env" to remote server.
This PR is adding "—skip_push" flag to "envify" command so it's possible to only generate it locally.